Set index mode earlier for new downsample index#106728
Merged
lkts merged 2 commits intoelastic:mainfrom Mar 26, 2024
Merged
Conversation
Downsample index is created using temporary index service using a static predefined subset of index settings. All other settings are later copied over from source index. As discovered in elastic#106338 this causes context like index mode to be missing during initial index creation process. This PR adds index mode and related required settings to initial set of index settings in order to have access to this information during initial create index operation.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
Author
|
I am relying on existing tests to cover this (there should be no changes in behavior anywhere, this PR just changes when something happens) and later it will be tested as part of #106338. |
martijnvg
approved these changes
Mar 26, 2024
Member
martijnvg
left a comment
There was a problem hiding this comment.
👍
I agree that existing tests should cover the correctness of this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downsample index is created using temporary index service using a
static predefined subset of index settings. All other settings are later
copied over from source index. As discovered in #106338 this causes
context like index mode to be missing during initial index creation
process. This PR adds index mode and related required settings to
initial set of index settings in order to have access to this
information during initial create index operation.