Skip to content

[DSL] Introduce data stream global retention - Part 3#105682

Merged
gmarouli merged 58 commits intoelastic:mainfrom
gmarouli:add-data-stream-global-retention-config
Mar 28, 2024
Merged

[DSL] Introduce data stream global retention - Part 3#105682
gmarouli merged 58 commits intoelastic:mainfrom
gmarouli:add-data-stream-global-retention-config

Conversation

@gmarouli
Copy link
Copy Markdown
Contributor

@gmarouli gmarouli commented Feb 21, 2024

In this PR we introduce the API that will expose the global retention configuration and will allow users to take advantage of it.

These APIs are protected by the dedicated introduced privileges:

  • manage_data_stream_global_retention or higher, which allows all operations on the global retention configuration
  • monitor_data_stream_retention or higher, which allows the retrieval of the global retention configuration

This PR is not delivering the complete feature since the global retention is not used yet.

Relevant documentation:

@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview:

@gmarouli gmarouli requested a review from masseyke February 21, 2024 13:52
@gmarouli gmarouli added the :StorageEngine/Data streams Data streams and their lifecycles label Feb 21, 2024
@gmarouli gmarouli marked this pull request as ready for review March 4, 2024 15:40
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Mar 4, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Mar 4, 2024

Investigating the bwc failures

@gmarouli
Copy link
Copy Markdown
Contributor Author

gmarouli commented Mar 4, 2024

The bwc failures, happened because of the missing feature health.extended_repository_indicator. It was fixed as soon as I updated the branch with main. I expect the tests will pass now.

"Explain backing index lifecycle":
- skip:
version: " - 8.13.99"
cluster_features: ["datastream_lifecycle", "data_stream.lifecycle.global_retention"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, much nicer than than specifying a numeric version. I think I need to go change a yaml test I just wrote ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also liked it a lot, but I couldn't make it work in one test. I do not know yet why, it's in my todo list to see if it has a conflict when there is a skip with a version in the setup step :(. It looks like it works in most tests though.

@gmarouli
Copy link
Copy Markdown
Contributor Author

I am leaning towards that test failure MixedClusterClientYamlTestSuiteIT » test {p0=mlt/30_unlike/Basic mlt query is not related to this PR. Because:

  • It is not using any lifecycle related features, it just creates an index and searches on it, so I can't imagine how this test can fail because of the global retention feature.
  • All the global retention tests are skipped because this test is using 7.17.19, so I do not see any test interference.
  • I found the same failure back in January.

Copy link
Copy Markdown
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great tutorial btw!

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @gmarouli, I've updated the changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Copy Markdown
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

@gmarouli according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is not labelled release highlight but the changelog has a highlight section

@gmarouli gmarouli deleted the add-data-stream-global-retention-config branch December 10, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants