[8.12] ESQL: Push CIDR_MATCH to Lucene if possible (#105061)#105177
Merged
costin merged 1 commit intoelastic:8.12from Feb 6, 2024
Merged
[8.12] ESQL: Push CIDR_MATCH to Lucene if possible (#105061)#105177costin merged 1 commit intoelastic:8.12from
costin merged 1 commit intoelastic:8.12from
Conversation
(cherry picked from commit b5f4c5e) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/EsqlTranslatorHandler.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizerTests.java
alex-spies
commented
Feb 6, 2024
| new ExpressionTranslators.StringQueries(), | ||
| new ExpressionTranslators.Matches(), | ||
| new ExpressionTranslators.MultiMatches(), | ||
| new Scalars() |
Contributor
Author
There was a problem hiding this comment.
Only this one is new, we were using the full list of QL translators before.
alex-spies
commented
Feb 6, 2024
| new AnalyzerContext(config, functionRegistry, getIndexResult, enrichResolution), | ||
| new Verifier(new Metrics()) | ||
| ); | ||
| private Analyzer makeAnalyzer(String mappingFileName, EnrichResolution enrichResolution) { |
Contributor
Author
There was a problem hiding this comment.
This is required for the backported test; to avoid code duplication in init, I updated init as well to be the same as in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.12: