Closed
Conversation
joshdover
reviewed
Jan 17, 2024
x-pack/plugin/core/template-resources/src/main/resources/logs-otel@mappings.json
Show resolved
Hide resolved
joshdover
reviewed
Jan 17, 2024
x-pack/plugin/core/template-resources/src/main/resources/logs-otel@mappings.json
Outdated
Show resolved
Hide resolved
felixbarny
commented
Jan 17, 2024
x-pack/plugin/core/template-resources/src/main/resources/logs-otel@mappings.json
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/template-resources/src/main/resources/logs-otel@mappings.json
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/template-resources/src/main/resources/logs-otel@mappings.json
Outdated
Show resolved
Hide resolved
This enables the *@Custom templates to override the built-in dynamic templates
ruflin
reviewed
Jul 1, 2024
| "type": "alias", | ||
| "path": "severity_text" | ||
| }, | ||
| "body_text": { |
Contributor
There was a problem hiding this comment.
It would be nice if this would instead be based on #109954 so both are the originals ...
Member
Author
There was a problem hiding this comment.
For these top-level fields, there should be a single source of truth. In the ES exporter, we have complete control over the document structure, and there should not be any custom fields at the root of the document. Only attributes contain dynamic parts.
3 tasks
Member
Author
|
Closing in favor of #111091 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.