Trigger parent circuit breaker when building scorers in filters aggregation#102511
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Nov 23, 2023
Merged
Trigger parent circuit breaker when building scorers in filters aggregation#102511elasticsearchmachine merged 3 commits intoelastic:mainfrom
elasticsearchmachine merged 3 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Collaborator
|
Hi @iverase, I've updated the changelog YAML for you. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have no means to estimate the size of a scorer in a filters aggregation, still can be big and lead to out of memory errors. This PR proposes to call the parent circuit breaker when creating them so we have a chance to circuit break in case we have many large queries. Note we can still go out of memory in case of one extremely large query.