Rivers: Add back deletion of river content on river removal.#10251
Closed
rjernst wants to merge 1 commit intoelastic:masterfrom
Closed
Rivers: Add back deletion of river content on river removal.#10251rjernst wants to merge 1 commit intoelastic:masterfrom
rjernst wants to merge 1 commit intoelastic:masterfrom
Conversation
In elastic#8877, the deletion of the type associated with a river was removed. This change adds back the removal using a scan search along with bulk delete requests.
Member
Author
|
@kimchy Is this what you were thinking? Can you suggest how to test? The tests for rivers seem...light. |
Contributor
|
@rjernst take a look at |
Contributor
|
Ha! I think I now understand why I can see a test failing in couchdb river in master. Related code in couchdb-river is https://github.com/elastic/elasticsearch-river-couchdb/blob/master/src/test/java/org/elasticsearch/river/couchdb/CouchdbRiverIntegrationTest.java#L456-457 I guess the test will be fix automagically when this PR will be merged. |
Member
Author
|
Closing since rivers have been removed from master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8877, the deletion of the type associated with a river was
removed. This change adds back the removal using a scan search
along with bulk delete requests.