Wipe shard state before switching recovered files live#10179
Merged
s1monw merged 1 commit intoelastic:masterfrom Mar 20, 2015
Merged
Wipe shard state before switching recovered files live#10179s1monw merged 1 commit intoelastic:masterfrom
s1monw merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@bleskes if you have a few moments |
Contributor
|
LGTM. Left a minor comment |
Today we leave the shard state behind even if a recovery is half finished this causes in rare conditions shards to be recovered and promoted as primaries that have never been fully recovered. Closes elastic#10053
Member
|
@s1monw it looks like this was just merged to master, is that correct? Can you label the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we leave the shard state behind even if a recovery is half finished
this causes in rare conditions shards to be recovered and promoted as
primaries that have never been fully recovered.
Closes #10053