Skip to content

[8.10] Backport Exclude desired_nodes validation tests from mixed-cluster QA#101421

Merged
ldematte merged 1 commit intoelastic:8.10from
ldematte:backport/8.10/100682
Oct 27, 2023
Merged

[8.10] Backport Exclude desired_nodes validation tests from mixed-cluster QA#101421
ldematte merged 1 commit intoelastic:8.10from
ldematte:backport/8.10/100682

Conversation

@ldematte
Copy link
Copy Markdown
Contributor

Backport of #100682 to 8.10

Closes #101419

@ldematte ldematte added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. backport labels Oct 27, 2023
@ldematte ldematte marked this pull request as ready for review October 27, 2023 08:50
@ldematte ldematte requested a review from kkrik-es October 27, 2023 10:23
// the nodes on current version. The rest client then round robins
// between the two nodes on old version. In order to unmute this,
// we need a different node selector, that always consistently
// selects the same node.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've actually tested this, it doesn't seem like to be the case.. Have you tried version skips for these tests and you still see them running in bwc tests?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind, this is to exclude the tests entirely.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly. In mixed clusters you start with a version and then upgrade it to current; you may talk to nodes on different versions, non predictably, and end up with different behaviour based on which node you are talking to.
Also, the version skip is already there and works well in non-mixed scenarios, but for these tests it seems to apply to the "start" (older) version, so once upgraded you have "worked around" the skip.
I think I've see in other tests that the version is read from the node(s) and a suitable node is selected, but it does not seem like this case.

@ldematte ldematte merged commit b1d736c into elastic:8.10 Oct 27, 2023
@ldematte ldematte deleted the backport/8.10/100682 branch October 27, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests v8.10.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants