Exclude synthetic source test for TSDB from mixedClusterTests#100592
Merged
kkrik-es merged 12 commits intoelastic:mainfrom Oct 11, 2023
Merged
Exclude synthetic source test for TSDB from mixedClusterTests#100592kkrik-es merged 12 commits intoelastic:mainfrom
kkrik-es merged 12 commits intoelastic:mainfrom
Conversation
# Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java # server/src/test/java/org/elasticsearch/index/mapper/SourceFieldMapperTests.java # server/src/test/java/org/elasticsearch/index/query/SearchExecutionContextTests.java
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
martijnvg
approved these changes
Oct 10, 2023
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - but let's run full bwc tests before merging?
Member
Author
|
Wow this made all the bwc tests between 8.7 and 8.10 to fail.. I'm dropping it. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We suspect the synthetic source test for tsdb mappings that was added in #98808 may be contributing to flakiness in mixed cluster tests.
This change also reverts #100572 since it doesn't work as expected - see comment below.
Fixes #100562