Skip to content

Avoid bubbling up exceptions from TransportService.sendRequest #89274

@andreidan

Description

@andreidan

Description

The sendRequest method is asynchronous and notifies a
TransportResponseHandler when it completes the excecution
(successfully or unsuccessfully).

When opening the connection we only catch NodeNotConnectedException
( https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/transport/TransportService.java#L719 ) which is currently fine as no implementations
throw other type of exception however, it'd be best to catch Exception here
so the handler gets notified of potential exceptions (as opposed to the caller
having to try/catch the call to sendRequest)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions