-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Fix split package LazySoftDeletesDirectoryReaderWrapper #81981
Copy link
Copy link
Closed
Labels
:Distributed/EngineAnything around managing Lucene and the Translog in an open shard.Anything around managing Lucene and the Translog in an open shard.:Search/SearchSearch-related issues that do not fall into other categoriesSearch-related issues that do not fall into other categories>bugTeam:DistributedMeta label for distributed team.Meta label for distributed team.Team:SearchMeta label for search teamMeta label for search team
Metadata
Metadata
Assignees
Labels
:Distributed/EngineAnything around managing Lucene and the Translog in an open shard.Anything around managing Lucene and the Translog in an open shard.:Search/SearchSearch-related issues that do not fall into other categoriesSearch-related issues that do not fall into other categories>bugTeam:DistributedMeta label for distributed team.Meta label for distributed team.Team:SearchMeta label for search teamMeta label for search team
Type
Fields
Give feedbackNo fields configured for issues without a type.
The last split package issue that we have between server and lucene is LazySoftDeletesDirectoryReaderWrapper. This was added early in 2021, so not one of the legacy hangovers from years gone by.
By inspecting the code, the three package-private member dependencies in
org.apache.lucene.indexbecome clear:First, LazySoftDeletesDirectoryReaderWrapper is only useful for read-only indices that are lazily loaded (a.k.a. frozen tier), so it is doubtful that Lucene would find it generally useful.
A note on each of the specific package-private API points:
[ the above notes are a summary of a discussion that included @romseygeek @jpountz, and @ywelsch ]
see #78166