Skip to content

Rewrite-to-filters optimization is very slow in FiltersAggregator #74480

@rafisism

Description

@rafisism

For my use-cases, the searches with heavily used Filters aggregations became about 20 times slower comparing version 7.10.2 and 7.13.2. The slowdown happened in version 7.11.0. And it is not just slower, it starts to return errors at high load very soon, where the older version works with 0% errors. Looked very similar to #73426

I took branch 7.13 and changed line 178 in server/src/main/java/org/elasticsearch/search/aggregations/bucket/filter/FiltersAggregator.java from
return parent == null && otherBucketKey == null;
to
return false;
And now it works fast again, even a bit faster than in 7.10.2

Could you do something like #73620 here too, please?

I know, ideally I need to provide a code and a test creating an index with mappings, indexing the data, and running a stress-test. The code change is very similar to #73620, but everything else is quite a lot of work. Please, let me know if you need anything.

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions