Skip to content

Rework fetching metrics from Aggregators so values are "always" calculated before fetching #67852

@nik9000

Description

@nik9000

#67839 has made it obvious that we need some kind of "safe" way to make sure that an aggregator is "all done". We used to have a postCollect phase but I removed it in #64016 because it we need to know which buckets we're building and we couldn't do that with postCollect. The thing is, if we're sorting on the value we need to finish for all keys. Or, at least the keys that we try to fetch metrics from. I feel like there is some "structural" way to do this so the way the code all hangs together we get the kind of behavior that we need implicitly. But I don't know what that structure is.

Relates to #66876. Fixing it will likely need that structure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions