-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Reloading analyzers doesn't bust the request cache #66722
Copy link
Copy link
Open
Labels
:Search Relevance/AnalysisHow text is split into tokensHow text is split into tokens>bugTeam:Search RelevanceMeta label for the Search Relevance team in ElasticsearchMeta label for the Search Relevance team in Elasticsearchpriority:normalA label for assessing bug priority to be used by ES engineersA label for assessing bug priority to be used by ES engineers
Metadata
Metadata
Assignees
Labels
:Search Relevance/AnalysisHow text is split into tokensHow text is split into tokens>bugTeam:Search RelevanceMeta label for the Search Relevance team in ElasticsearchMeta label for the Search Relevance team in Elasticsearchpriority:normalA label for assessing bug priority to be used by ES engineersA label for assessing bug priority to be used by ES engineers
Type
Fields
Give feedbackNo fields configured for issues without a type.
When working on #66295 @jtibshirani realized that reloading analyzers also doesn't clear the request cache when it probably should. We expect most folks that reload search analyzers probably aren't going to bump into this because they are likely to have non-0 top hits so they won't have the cache enabled by default. But search analyzers can play a part in queries the kind of pure aggregation queries that enable the request cache by default - they can filter the data seen by aggs and they define the
filtersaggs. Busting the cache when the analyzers is the safest thing from a "correctness" stand point. It is rare so it shouldn't cause a huge performance hit.