Add new flag to check whether alias exists on remove#58100
Merged
ywelsch merged 4 commits intoelastic:masterfrom Jun 18, 2020
Merged
Add new flag to check whether alias exists on remove#58100ywelsch merged 4 commits intoelastic:masterfrom
ywelsch merged 4 commits intoelastic:masterfrom
Conversation
ywelsch
commented
Jun 16, 2020
| similar to <<index-hidden,hidden indices>>. This property must be set to the | ||
| same value on all indices that share an alias. Defaults to `false`. | ||
|
|
||
| `must_exist`:: |
Contributor
Author
There was a problem hiding this comment.
I was not sure about the naming here. Initially I went with "required", but I felt that that was a bit too generic, so opted for a word where it's at least clear what is meant.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
martijnvg
approved these changes
Jun 17, 2020
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM. I left testing nits.
Regarding the name of the new flag, I think must_exist is good.
(I can't think of a better name and it is more descriptive than required)
ywelsch
added a commit
that referenced
this pull request
Jun 18, 2020
This allows doing true CAS operations on aliases, making sure that an alias is actually properly moved from a given source index onto a given target index. This is useful to ensure that an alias is actually moved from a given index to another one, and not just added to another index.
ywelsch
added a commit
that referenced
this pull request
Jun 18, 2020
29 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#58100 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#58100 Co-authored-by: Russ Cam <russ.cam@elastic.co>
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 17, 2020
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <javanna@users.noreply.github.com>
henningandersen
added a commit
that referenced
this pull request
Nov 18, 2020
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 18, 2020
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <javanna@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows doing true CAS operations on aliases, making sure that an alias is actually properly moved from a given source index onto a given target index. This is useful to ensure that an alias is actually moved from a given index to another one, and not just added to another index.