-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[discovery-ec2] Plugin doesn't retry EC2 describe instance calls #50462
Copy link
Copy link
Closed
Labels
:Distributed/Discovery-PluginsAnything related to our integration plugins with EC2, GCP and AzureAnything related to our integration plugins with EC2, GCP and Azure>bug
Description
Problem Description
Discovery EC2 doesn't retry EC2 describe calls on throttle or exceptions due to NO_RETRY_CONDITION which has the potential to make the throttling worse. Although there is a logic to exponentially backoff in such cases, backoff doesn't kick in.
Lines 82 to 90 in 7203cee
| RetryPolicy.RetryCondition.NO_RETRY_CONDITION, | |
| (originalRequest, exception, retriesAttempted) -> { | |
| // with 10 retries the max delay time is 320s/320000ms (10 * 2^5 * 1 * 1000) | |
| logger.warn("EC2 API request failed, retry again. Reason was:", exception); | |
| return 1000L * (long) (10d * Math.pow(2, retriesAttempted / 2.0d) * (1.0d + rand.nextDouble())); | |
| }, | |
| 10, | |
| false); | |
| clientConfiguration.setRetryPolicy(retryPolicy); |
AWS reference
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Distributed/Discovery-PluginsAnything related to our integration plugins with EC2, GCP and AzureAnything related to our integration plugins with EC2, GCP and Azure>bug
Type
Fields
Give feedbackNo fields configured for issues without a type.