-
Notifications
You must be signed in to change notification settings - Fork 25.8k
REST client - Response.getWarnings() does not decode escaped quotes #38189
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
:Clients/Java Low Level REST ClientMinimal dependencies Java Client for ElasticsearchMinimal dependencies Java Client for Elasticsearch>bugTeam:Data Management (obsolete)DO NOT USE. This team no longer exists.DO NOT USE. This team no longer exists.
Description
I ran into a failing test scenario where the Java string logged server-side with the DeprecationLogger.deprecatedAndMaybeLog failed to match the same string when materialized client-side using Response. getWarnings().
The string in question had quotes eg:
public static final String DEPRECATION_MESSAGE = "Don't use \"type\" please";
which is encoded to HTTP headers by the logging framework with slashes around the quotes eg Don't use \"type\" please
When deserialized on the client the slashes are not decoded meaning our test fails because Don't use \"type\" please != Don't use "type" please
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Clients/Java Low Level REST ClientMinimal dependencies Java Client for ElasticsearchMinimal dependencies Java Client for Elasticsearch>bugTeam:Data Management (obsolete)DO NOT USE. This team no longer exists.DO NOT USE. This team no longer exists.
Type
Fields
Give feedbackNo fields configured for issues without a type.