-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Run code snippets in ReindexDocumentationIT #32093
Copy link
Copy link
Closed
Labels
:Distributed/CRUDA catch all label for issues around indexing, updating and getting a doc by id. Not search.A catch all label for issues around indexing, updating and getting a doc by id. Not search.>docsGeneral docs changesGeneral docs changes>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testshelp wantedadoptmeadoptme
Description
Currently it seems we don't run any of the documentation code snippets in ReindexDocumentationIT.
Test methods don't start with the "test..." prefix, so we don't catch any errors in the documented code snippets other
than compile errors. I think the snippets should be run like in other code documentation tests. However this might
require some additional test setup code. Also I think the api responses require some basic assertions.
Otherwiew we miss errors like the one reported in #32010.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Distributed/CRUDA catch all label for issues around indexing, updating and getting a doc by id. Not search.A catch all label for issues around indexing, updating and getting a doc by id. Not search.>docsGeneral docs changesGeneral docs changes>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testshelp wantedadoptmeadoptme
Type
Fields
Give feedbackNo fields configured for issues without a type.