-
Notifications
You must be signed in to change notification settings - Fork 25.8k
SQL: Align class packages in sql-proto and shared-proto projects #31593
Copy link
Copy link
Closed
Labels
Description
Looks like a left-over from the various class movements:
-
the package name of the
sql-protoproject issql.plugin. This is incorrect and misleading since that's the package of the server. It should be changed to something more appropriate likesql.protoor (to avoid a cycle with 2 below) `sql.proto.action. -
the package name of the shared-proto project is
sql.proto. Due to 1 above, it should besql.proto.sharedor (since that creates a cycle betweenproto.sharedandproto) tosql.shared.protoorsql.proto.common.
That is, the package name should properly convey the project name and the hierarchy (sql-proto depends on shared-proto not vice versa) without splitting an existing package name.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.