-
Notifications
You must be signed in to change notification settings - Fork 25.8k
RollupIT disables all thread leak detection #31258
Copy link
Copy link
Closed
Labels
:StorageEngine/RollupTurn fine-grained time-based data into coarser-grained dataTurn fine-grained time-based data into coarser-grained data
Description
Currently the main rollup integration test disables all thread leak detection:
elasticsearch/x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/RollupIT.java
Lines 64 to 65 in 2efd224
| @ThreadLeakScope(ThreadLeakScope.Scope.NONE) | |
| public class RollupIT extends ESIntegTestCase { |
I think that this should be unnecessary, I think that the only thread that should be filtered out here is the ObjectCleanerThread from Netty (relates #31232). It looks like this was added for the trigger_engine_scheduler thread. Can we look into this and see if the thread leak none can be removed and reduced to filter the ObjectCleanerThread only (extend XPackIntegTestCase)?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:StorageEngine/RollupTurn fine-grained time-based data into coarser-grained dataTurn fine-grained time-based data into coarser-grained data
Type
Fields
Give feedbackNo fields configured for issues without a type.