-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Same origin CORS logic does not consider scheme or port #30988
Copy link
Copy link
Open
Labels
:Distributed/NetworkHttp and internode communication implementationsHttp and internode communication implementations>bug>tech-debtTeam:DistributedMeta label for distributed team.Meta label for distributed team.
Description
When introducing Cors for the nio http server transport, an issue was raised by @tvernum with our current Cors logic. Currently we set the "access-control-allow-origin" response header to to the request "origin" header if the host is the same. This is based on our expectation that this is the same origin.
However, in the Cors sense, an origin is (scheme, host, port). So this logic does not make sense. Additionally, it is not clear if we need to check if the origin is the same as that would not be a cross-origin resource sharing request.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Distributed/NetworkHttp and internode communication implementationsHttp and internode communication implementations>bug>tech-debtTeam:DistributedMeta label for distributed team.Meta label for distributed team.
Type
Fields
Give feedbackNo fields configured for issues without a type.