-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Remove S3OutputStream in favor of TransferManager #26993
Copy link
Copy link
Closed
Labels
:Distributed/Snapshot/RestoreAnything directly related to the `_snapshot/*` APIsAnything directly related to the `_snapshot/*` APIs>enhancement
Description
Related to #26969, the AWS SDK has improved since Elasticsearch 1.4 and I think it's more than time to remove the S3OutputStream class and to replace it by other utilities provided by the AWS SDK. I'd like to replace it with com.amazonaws.services.s3.transfer.TransferManager (from AWS SDK v1.11.211) which takes care of uploading objects using one or multiple requests, potentially by executing them concurrently.
With the security manager enabled and all the legacy code in the S3 plugin the change is not that simple but I'd like to do it soon. I think we can expect less GCs, less allocations, less connections issues and upload should be faster too. That's also the opportunity to prepare the field for AWS SDK v2.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Distributed/Snapshot/RestoreAnything directly related to the `_snapshot/*` APIsAnything directly related to the `_snapshot/*` APIs>enhancement
Type
Fields
Give feedbackNo fields configured for issues without a type.