-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Add tests for building SuggestionSearchContext from suggestion builders #17118
Copy link
Copy link
Closed
Labels
:Search Relevance/Suggesters"Did you mean" and suggestions as you type"Did you mean" and suggestions as you type>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:Search RelevanceMeta label for the Search Relevance team in ElasticsearchMeta label for the Search Relevance team in Elasticsearch
Description
When we complete the current refactoring of the suggestion builders (#17096), we should add tests that check the output of the suggestion builders build() method, similar to what we did when refactoring the query builders. While we were refactoring the suggestion builders, we temporarily added tests that check that the results of parsing a builder in its xContent representation and calling the build() methods resulted in the same SuggestionSearchContext. After the deletion of SuggestParseElement we cannot use this kind of similarity check any more, so we need dedicated unit tests for that.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Search Relevance/Suggesters"Did you mean" and suggestions as you type"Did you mean" and suggestions as you type>enhancement>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:Search RelevanceMeta label for the Search Relevance team in ElasticsearchMeta label for the Search Relevance team in Elasticsearch
Type
Fields
Give feedbackNo fields configured for issues without a type.