-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Don't cancel allocation when a new sync id is found on shared filesystems #16357
Copy link
Copy link
Closed
Labels
:Distributed/AllocationAll issues relating to the decision making around placing a shard (both master logic & on the nodes)All issues relating to the decision making around placing a shard (both master logic & on the nodes)>enhancement
Description
In ReplicaShardAllocator.processExistingRecoveries, if we find a "better" match, we cancel allocation of a replica:
// we found a better match that has a full sync id match, the existing allocation is not fully synced
// so we found a better one, cancel this one
it.moveToUnassigned(new UnassignedInfo(UnassignedInfo.Reason.REALLOCATED_REPLICA,
"existing allocation of replica to [" + currentNode + "] cancelled, sync id match found on node [" + nodeWithHighestMatch + "]"));However, when on a shared filesystem, all data nodes have the same data, so we should not cancel allocation if a new node pops up.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Distributed/AllocationAll issues relating to the decision making around placing a shard (both master logic & on the nodes)All issues relating to the decision making around placing a shard (both master logic & on the nodes)>enhancement
Type
Fields
Give feedbackNo fields configured for issues without a type.