-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Improve circuit breaking on aggregations #14046
Copy link
Copy link
Closed
Labels
:Analytics/AggregationsAggregationsAggregations:Core/Infra/Circuit BreakersTrack estimates of memory consumption to prevent overloadTrack estimates of memory consumption to prevent overload>featurehelp wantedadoptmeadoptmehigh hanging fruit
Description
Unfortunately circuit breaking on aggregations only catches a small subset of out-of-memory errors. I was talking with @dakrone recently who had the interesting idea to also count how many aggregators we create and use it for circuit-breaking. I think it would be a good heuristic to avoid out-of-memory errors in the deeply-nested aggregation case that we often see.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Analytics/AggregationsAggregationsAggregations:Core/Infra/Circuit BreakersTrack estimates of memory consumption to prevent overloadTrack estimates of memory consumption to prevent overload>featurehelp wantedadoptmeadoptmehigh hanging fruit
Type
Fields
Give feedbackNo fields configured for issues without a type.