Original issue for TOP: #134293
Found aggs:
Still, double check again in case there's some missing, I just searched for public Expression surrogate() {.
Also, we could use having some automatic test case for this. A check for all aggregates that ensure that the filter isn't lost if it returns another agg.
Open questions
If we surrogate an agg to a normal function, the filter is lost. But will the value be correct? Add test cases, if none.
E.g.
|
return new MvPercentile(source(), new ToDouble(source(), field), percentile()); |
Original issue for TOP: #134293
Found aggs:
Still, double check again in case there's some missing, I just searched for
public Expression surrogate() {.Also, we could use having some automatic test case for this. A check for all aggregates that ensure that the filter isn't lost if it returns another agg.
Open questions
If we surrogate an agg to a normal function, the filter is lost. But will the value be correct? Add test cases, if none.
E.g.
elasticsearch/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Percentile.java
Line 180 in e239113