-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Refine LOOKUP JOIN types IT #127819
Copy link
Copy link
Open
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)
Metadata
Metadata
Assignees
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)
Type
Fields
Give feedbackNo fields configured for issues without a type.
The PR at #126150 introduced an integration test that looked at all combinations of left-vs-right types during LOOKUP JOIN and made assertions on whether they should succeed or fail. The review comments pointed out that instead of making many different lookup indices for each type, we could just have one main and one lookup index, each with fields for all types, and use
RENAMEto allow mixed-type testing.This issue recommends making exactly that simplification. It should make the code easier to follow as well as improve test performance. Previously about half of the 20s the test took to run was likely index setup. This could be reduced quite a bit.