-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Simplify BalanceUnbalancedClusterTest #12629
Copy link
Copy link
Closed
Labels
:Distributed/AllocationAll issues relating to the decision making around placing a shard (both master logic & on the nodes)All issues relating to the decision making around placing a shard (both master logic & on the nodes)>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:DistributedMeta label for distributed team.Meta label for distributed team.team-discuss
Metadata
Metadata
Assignees
Labels
:Distributed/AllocationAll issues relating to the decision making around placing a shard (both master logic & on the nodes)All issues relating to the decision making around placing a shard (both master logic & on the nodes)>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:DistributedMeta label for distributed team.Meta label for distributed team.team-discuss
Type
Fields
Give feedbackNo fields configured for issues without a type.
This takes 10 seconds or more, while other allocation tests are almost instantaneous. Can we simplify this? It looks like it tries to do a basic allocation (5 shards, 1 replica) of a new index when a ton of indexes already exist on just 4 nodes. Perhaps we could test similar circumstances without thousands of shards? Alternatively, we could just make this an integration test (leave the impl, but rename to IT). It doesn't really seem like a unit test as it is now.
Also, as a side note, this test is the only user of CatAllocationTestCase. Perhaps we can also eliminate this abstraction and just test directly (eliminating the zipped shard state)? @s1monw do you have any thoughts here?