Currently block loader tests for mappers are coupled to synthetic source test infrastructure. As a result, changing synthetic source implementation/tests results in unintended changes to block loader tests and block loader tests are limited to only test scenarios that make sense for synthetic source (!). Additionally block loader tests use synthetic source infrastructure to test block loaders without synthetic source which makes it hard to understand what's going on and leads to complicated implementation of syntheticSourceSupport.
Example:
|
public MapperTestCase.SyntheticSourceExample example(int maxValues, boolean loadBlockFromSource) { |
We would like to consider decoupling such tests possibly utilizing logsdb data generation infrastructure.
Currently block loader tests for mappers are coupled to synthetic source test infrastructure. As a result, changing synthetic source implementation/tests results in unintended changes to block loader tests and block loader tests are limited to only test scenarios that make sense for synthetic source (!). Additionally block loader tests use synthetic source infrastructure to test block loaders without synthetic source which makes it hard to understand what's going on and leads to complicated implementation of
syntheticSourceSupport.Example:
elasticsearch/test/framework/src/main/java/org/elasticsearch/index/mapper/KeywordFieldSyntheticSourceSupport.java
Line 52 in eae3a42
We would like to consider decoupling such tests possibly utilizing logsdb data generation infrastructure.