Avoiding server hanging on close

masseyke · masseyke · commit fa87b0b1899a · 2023-03-02T08:37:01.000-06:00
diff --git a/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/logging/DeprecationIndexingComponent.java b/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/logging/DeprecationIndexingComponent.java
@@ -172,7 +172,9 @@ protected void doStop() {
 
     @Override
     protected void doClose() {
-        this.processor.close();
+        if (requestAndListenerBuffer.isEmpty()) {
+            this.processor.close();
+        } // else no point in waiting for the bulk requests to complete because they're never going to
     }
 
     public void enableDeprecationLogIndexing(boolean newEnabled) {

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,9 @@ protected void doStop() {`
`172`	`172`
`173`	`173`	`@Override`
`174`	`174`	`protected void doClose() {`
`175`		`- this.processor.close();`
	`175`	`+ if (requestAndListenerBuffer.isEmpty()) {`
	`176`	`+ this.processor.close();`
	`177`	`+ } // else no point in waiting for the bulk requests to complete because they're never going to`
`176`	`178`	`}`
`177`	`179`
`178`	`180`	`public void enableDeprecationLogIndexing(boolean newEnabled) {`