No need to check the stale ids

dnhatn · dnhatn · commit b0cd95476487 · 2018-02-08T11:11:05.000-05:00
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/allocation/IndexMetaDataUpdater.java b/server/src/main/java/org/elasticsearch/cluster/routing/allocation/IndexMetaDataUpdater.java
@@ -239,11 +239,7 @@ public static ClusterState removeStaleIdsWithoutRoutings(ClusterState clusterSta
                     }
                     indexMetaDataBuilder.putInSyncAllocationIds(shardNumber, remainingInSyncAllocations);
                 }
-                // Only log the stale shards which have been actually removed.
-                if (oldInSyncAllocations.size() != remainingInSyncAllocations.size()) {
-                    logger.warn("{} remove stale shards [{}] without routing", shardEntry.getKey(),
-                        Sets.difference(oldInSyncAllocations, remainingInSyncAllocations));
-                }
+                logger.warn("{} marking unavailable shards as stale: {}", shardEntry.getKey(), idsToRemove);
             }
 
             if (indexMetaDataBuilder != null) {

Original file line number	Diff line number	Diff line change
`@@ -239,11 +239,7 @@ public static ClusterState removeStaleIdsWithoutRoutings(ClusterState clusterSta`
`239`	`239`	`}`
`240`	`240`	`indexMetaDataBuilder.putInSyncAllocationIds(shardNumber, remainingInSyncAllocations);`
`241`	`241`	`}`
`242`		`- // Only log the stale shards which have been actually removed.`
`243`		`- if (oldInSyncAllocations.size() != remainingInSyncAllocations.size()) {`
`244`		`- logger.warn("{} remove stale shards [{}] without routing", shardEntry.getKey(),`
`245`		`- Sets.difference(oldInSyncAllocations, remainingInSyncAllocations));`
`246`		`- }`
	`242`	`+ logger.warn("{} marking unavailable shards as stale: {}", shardEntry.getKey(), idsToRemove);`
`247`	`243`	`}`
`248`	`244`
`249`	`245`	`if (indexMetaDataBuilder != null) {`