fix sort

dnhatn · dnhatn · commit 82f8e1307c27 · 2026-03-12T22:42:38.000-07:00
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/TsidBuilder.java b/server/src/main/java/org/elasticsearch/cluster/routing/TsidBuilder.java
@@ -221,8 +221,6 @@ public MurmurHash3.Hash128 hash() {
     }
 
     public final BytesRef buildTsid(IndexVersion indexVersion) {
-        throwIfEmpty();
-        Collections.sort(dimensions);
         if (indexVersion.onOrAfter(IndexVersions.CLUSTERING_TSID)) {
             return buildClusteringTsid();
         } else {
@@ -253,6 +251,9 @@ public final BytesRef buildTsid(IndexVersion indexVersion) {
      * @throws IllegalArgumentException if no dimensions have been added
      */
     public BytesRef buildLegacyTsid() {
+        throwIfEmpty();
+        Collections.sort(dimensions);
+
         int numberOfValues = Math.min(MAX_TSID_VALUE_SIMILARITY_FIELDS, dimensions.size());
         byte[] hash = new byte[1 + numberOfValues + 16];
         int index = 0;
@@ -293,6 +294,9 @@ public BytesRef buildLegacyTsid() {
     }
 
     private BytesRef buildClusteringTsid() {
+        throwIfEmpty();
+        Collections.sort(dimensions);
+
         final byte[] tsid = new byte[16];
         murmur3Hasher.reset();
         MurmurHash3.Hash128 hashBuffer = new MurmurHash3.Hash128();
