Fixes HeartbeatSerializationTests (#139991)

joshua-adams-1 · web-flow · commit 745fa172e2a0 · 2026-01-05T10:52:45.000Z
Fixes a bug in HeartbeatSerializationTests.mutateInstance where the
randomly mutated HeartBeat could have had the same value as before
diff --git a/server/src/test/java/org/elasticsearch/cluster/coordination/stateless/HeartbeatSerializationTests.java b/server/src/test/java/org/elasticsearch/cluster/coordination/stateless/HeartbeatSerializationTests.java
@@ -11,6 +11,7 @@
 
 import org.elasticsearch.common.io.stream.Writeable;
 import org.elasticsearch.test.AbstractWireSerializingTestCase;
+import org.elasticsearch.test.ESTestCase;
 
 import java.io.IOException;
 
@@ -22,19 +23,15 @@ protected Writeable.Reader<Heartbeat> instanceReader() {
 
     @Override
     protected Heartbeat createTestInstance() {
-        return new Heartbeat(randomPositiveLong(), randomPositiveLong());
+        return new Heartbeat(randomNonNegativeLong(), randomNonNegativeLong());
     }
 
     @Override
     protected Heartbeat mutateInstance(Heartbeat instance) throws IOException {
         if (randomBoolean()) {
-            return new Heartbeat(randomPositiveLong(), instance.absoluteTimeInMillis());
+            return new Heartbeat(randomValueOtherThan(instance.term(), ESTestCase::randomNonNegativeLong), instance.absoluteTimeInMillis());
         } else {
-            return new Heartbeat(instance.term(), randomPositiveLong());
+            return new Heartbeat(instance.term(), randomValueOtherThan(instance.absoluteTimeInMillis(), ESTestCase::randomNonNegativeLong));
         }
     }
-
-    private long randomPositiveLong() {
-        return randomLongBetween(0, Long.MAX_VALUE);
-    }
 }
