More tightening of shard state action tests

jasontedor · jasontedor · commit 386d2ab86a33 · 2016-01-17T10:36:24.000-05:00
This commit adds some additional assertions that test success is not
falsely indicated by adding assertions that success / failure methods
are not incorrectly invoked in failure / success scenarios.
diff --git a/core/src/test/java/org/elasticsearch/cluster/action/shard/ShardStateActionTests.java b/core/src/test/java/org/elasticsearch/cluster/action/shard/ShardStateActionTests.java
@@ -140,6 +140,13 @@ public void onSuccess() {
                 success.set(true);
                 latch.countDown();
             }
+
+            @Override
+            public void onShardFailedFailure(Exception e) {
+                success.set(false);
+                latch.countDown();
+                assert false;
+            }
         });
 
         CapturingTransport.CapturedRequest[] capturedRequests = transport.getCapturedRequestsAndClear();
@@ -181,6 +188,13 @@ public void onSuccess() {
                 success.set(true);
                 latch.countDown();
             }
+
+            @Override
+            public void onShardFailedFailure(Exception e) {
+                success.set(false);
+                latch.countDown();
+                assert false;
+            }
         });
 
         latch.await();
@@ -224,6 +238,7 @@ public void onShardFailedFailure(Exception e) {
                 success.set(false);
                 exception.set(e);
                 latch.countDown();
+                assert false;
             }
         });
 
@@ -251,6 +266,7 @@ public void testUnhandledFailure() {
         shardStateAction.shardFailed(getRandomShardRouting(index), indexUUID, "test", getSimulatedFailure(), new ShardStateAction.Listener() {
             @Override
             public void onSuccess() {
+                failure.set(false);
                 assert false;
             }
 
