Add minimal OpenTelemetry instrumentation#150
Merged
pquentin merged 3 commits intoelastic:mainfrom Feb 21, 2024
Merged
Conversation
18 tasks
xrmx
reviewed
Feb 20, 2024
Member
xrmx
left a comment
There was a problem hiding this comment.
OT but you probably shouldn't need mock in extras_require too
xrmx
approved these changes
Feb 21, 2024
Member
xrmx
left a comment
There was a problem hiding this comment.
Given that I'm mostly clueless about this, the python implementation resembles the ruby one and this will help to move the ball forward it LGTM.
|
hey @pquentin I'm late to the party but this LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates elastic/elasticsearch-py#2435
This pull request introduces minimal OpenTelemetry instrumentation, without:
However, it contains the basic scaffolding and can be used to send a basic trace containing the method name to Elastic APM:
Thanks @estolfo for the help. As you know, I was heavily inspired by the Ruby implementation.