[System test runner] Assign to the deployed service context#99
Merged
mtojek merged 1 commit intoelastic:masterfrom Sep 16, 2020
Merged
Conversation
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
|
5 tasks
mtojek
reviewed
Sep 16, 2020
| } | ||
| service.stdout = outFile | ||
| ctxt.STDOUT = agentLogsFolder + stdoutFileName | ||
| service.ctxt.STDOUT = agentLogsFolder + stdoutFileName |
Contributor
There was a problem hiding this comment.
In general we shouldn't modify the context as service property, but rather build the new context first and then assign to the service.
Let's keep it here for now as we're in the middle of debugging the issue.
Contributor
|
Let me merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug where we were setting the
STDOUTandSTDERRfields on the context passed in to aServiceDeployer'sSetUpmethod. Instead we should be setting these on the context of theDeployedServicereturned from this method.