Check values against list of expected values#865
Merged
jsoriano merged 1 commit intoelastic:mainfrom Jun 24, 2022
Merged
Conversation
mtojek
approved these changes
Jun 24, 2022
Member
Author
|
Please don't merge till #864 (comment) is resolved. I opened the PR to have it ready before integrations start using ECS versions with these |
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Collaborator
🌐 Coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since elastic/ecs#1952, ECS fields can contain a list of expected values.
Check that imported fields comply with these values.
Similar to #771, but for
expected_values.It won't affect current integrations because no ECS version has been released yet with
expected_values.Fixes #864.