Support different Kibana configs based on stack version#553
Support different Kibana configs based on stack version#553mtojek merged 13 commits intoelastic:masterfrom
Conversation
|
/test |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
left a comment
There was a problem hiding this comment.
Looks good, and I agree with the follow ups. There may be more changes needed if more breaking changes are introduced till 8.0 is released, but let's merge this if this unblocks the use of 8.x stacks by now.
Makefile
Outdated
| test-stack-command-default: | ||
| ./scripts/test-stack-command.sh | ||
|
|
||
| test-stack-command-lts: |
There was a problem hiding this comment.
Nit.
| test-stack-command-lts: | |
| test-stack-command-7x: |
| withEnv(stackVariantAsEnv(options.StackVersion)). | ||
| withEnvs(options.Profile.ComposeEnvVars()). |
There was a problem hiding this comment.
I wonder if we can encapsulate all the particularities for a given version in the profile.
There was a problem hiding this comment.
First we have to clean this dependency hell around profiles, but in general I agree with you.
Issue: #552
This PR introduces a mechanism to support multiple Kibana config files to mitigate problems with starting the 8.x stack. There are lot of changes due to "profiles" support and this is something we need to address in follow-ups.
Follow-ups:
KibanaConfigFileaffected too many places)