Skip to content

Fix issue that removed entries from lists in policy tests#3268

Merged
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:policy-test-replace
Feb 11, 2026
Merged

Fix issue that removed entries from lists in policy tests#3268
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:policy-test-replace

Conversation

@jsoriano
Copy link
Member

memberReplace, when used on slices, was removing them instead of replacing its members. Add explicit support for them.

Also fix a type check whose condition was reversed.

Add tests that reproduce the issues that this change solves.

Change prepared with assistance by copilot.

@jsoriano jsoriano requested a review from a team February 10, 2026 17:50
@jsoriano jsoriano self-assigned this Feb 10, 2026
@jsoriano
Copy link
Member Author

test integrations

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#17353

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 10, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @jsoriano

Copy link
Contributor

@teresaromero teresaromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the fix with mysql package, and now i am getting the elasticsearch exporter. however, i don't quite understand why this was failing and how come i did not get the exporter 🤔 could you elaborate more on this?

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsoriano jsoriano merged commit 3a873d6 into elastic:main Feb 11, 2026
3 checks passed
@jsoriano jsoriano deleted the policy-test-replace branch February 11, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants