Update command used for cloud-reaper tool#3198
Merged
mrodm merged 10 commits intoelastic:mainfrom Jan 20, 2026
Merged
Conversation
Collaborator
💚 Build Succeeded
History
cc @mrodm |
mrodm
commented
Jan 14, 2026
|
|
||
| RESOURCE_RETENTION_PERIOD="${RESOURCE_RETENTION_PERIOD:-"24 hours"}" | ||
| DRY_RUN="$(buildkite-agent meta-data get DRY_RUN --default "${DRY_RUN:-"true"}")" | ||
| RESOURCE_RETENTION_PERIOD="$(buildkite-agent meta-data get RESOURCE_RETENTION_PERIOD --default "${RESOURCE_RETENTION_PERIOD:-"24 hours"}")" |
Contributor
Author
There was a problem hiding this comment.
Allow to overwrite the Retention Period via buildkite input parameter. This could be helpful for testing or debugging triggering the pipeline via UI.
mrodm
commented
Jan 14, 2026
| key: "RESOURCE_RETENTION_PERIOD" | ||
| required: false | ||
| default: "24 hours" | ||
| if: "build.source == 'ui'" |
Contributor
Author
There was a problem hiding this comment.
Required to avoid triggering this input block in the pipeline triggered by the daily CI jobs.
mrodm
commented
Jan 14, 2026
| # TODO: to be changed to "destroy --confirm" once it can be tested | ||
| # that filters work as expected | ||
| COMMAND="plan" | ||
| COMMAND="destroy --confirm" |
Contributor
Author
There was a problem hiding this comment.
As it has been tested with stale resources, I think this can be changed to run the destroy command if DRY_RUN false.
teresaromero
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the cloud-reaper command used when DRY_RUN false is set to be
destroy --confirm.This PR also updates how the output of the tool is scanned to detect failures.
Related BK builds:
Addition: