internal/testrunner/runners/system: export policy helper functions#2984
Merged
efd6 merged 1 commit intoelastic:mainfrom Oct 12, 2025
Merged
internal/testrunner/runners/system: export policy helper functions#2984efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
Export and liberate from method status: * CreatePackageDatastream * BuildDataStreamName * BuildIndexTemplateName * FindPolicyTemplateForInput * SelectPolicyTemplateByName Also harmonise pointiness of parameter types to avoid copies.
Collaborator
💚 Build Succeeded
cc @efd6 |
Comment on lines
-1912
to
+1914
| config testConfig, | ||
| cfgName string, | ||
| cfgVars, cfgDSVars common.MapStr, |
Member
There was a problem hiding this comment.
Nice changes to be more specific on the inputs needed 👍
| func createPackageDatastream( | ||
| kibanaPolicy kibana.Policy, | ||
| pkg packages.PackageManifest, | ||
| func CreatePackageDatastream( |
Member
There was a problem hiding this comment.
I wonder if these functions could be moved to some common package now that they are going to be used in multiple test runners. Similar functions probably exist too in benchmark runners.
Contributor
Author
There was a problem hiding this comment.
The names they have now are meaningful, system.X, moving to a "common" package would no doubt result in the use of a "common" package name. https://go.dev/talks/2014/names.slide#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export and liberate from method status:
Also harmonise pointiness of parameter types to avoid copies.
For #2868
Please take a look.