internal/testrunner/runners/system: export fields query and result container type#2983
Merged
efd6 merged 1 commit intoelastic:mainfrom Oct 12, 2025
Merged
internal/testrunner/runners/system: export fields query and result container type#2983efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
💚 Build Succeeded
cc @efd6 |
jsoriano
approved these changes
Oct 10, 2025
| } | ||
| }` | ||
|
|
||
| type FieldsQueryResult struct { |
Member
There was a problem hiding this comment.
I wonder if this type should be moved to internal/elasticsearch.
Contributor
Author
There was a problem hiding this comment.
It relates to system tests, so I don't think so.
| "github.com/elastic/elastic-package/internal/wait" | ||
| ) | ||
|
|
||
| const FieldsQuery = `{ |
Member
There was a problem hiding this comment.
This name seems too generic, I wonder if we should refer to the kind of request this is used for.
Suggested change
| const FieldsQuery = `{ | |
| const SearchDocsQueryBody = `{ |
Contributor
Author
There was a problem hiding this comment.
I'm not sure that the extra words carry any more useful information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2868
Please take a look.