Assert no errors are in pipeline tests#290
Merged
mtojek merged 3 commits intoelastic:masterfrom Mar 15, 2021
Merged
Conversation
Contributor
Author
|
/test |
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
ycombinator
reviewed
Mar 15, 2021
| for _, event := range result.events { | ||
| err := checkErrorMessage(event) | ||
| if err != nil { | ||
| multiErr = append(multiErr, err) |
Contributor
There was a problem hiding this comment.
Should we continue here? IOW, should we check fields in the event if we find the error.message field?
Contributor
Author
There was a problem hiding this comment.
Hmm... maybe you're right. Actually all other fields can be wrong, e.g. should be removed but weren't due to an error.
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #281