Refactor survey validators to don't need chdirs#2798
Merged
jsoriano merged 1 commit intoelastic:mainfrom Aug 1, 2025
Merged
Conversation
Collaborator
💚 Build Succeeded
cc @jsoriano |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #2796, these would be the last use of chdir in tests.
Chdir can be problematic because it is global, and might affect other tests, or other functions tested in the same test. It is also error-prone as one may forget to go back to the previous working directory.
An object is created now that can keep as context the working directory, and validators are added as members of this object.