Merged
Conversation
mrodm
approved these changes
Jun 26, 2025
Contributor
mrodm
left a comment
There was a problem hiding this comment.
Thanks!!
Just added some minor comments.
|
|
||
| For legacy reasons, integration packages can be used for most use cases. For | ||
| example a package can include dashboards without including any data stream, as | ||
| if it were a content package. Or an integration package can define a single data |
Contributor
There was a problem hiding this comment.
Suggested change
| if it were a content package. Or an integration package can define a single data | |
| if it was a content package. Or an integration package can define a single data |
Member
Author
There was a problem hiding this comment.
I think were is correct here 🤔
Contributor
There was a problem hiding this comment.
mmm now I have doubts 😅
Probably, you're right and it should be as if it were... as an hypothetical situation.
Member
There was a problem hiding this comment.
Native English speaker here 👋 - both sound fine imo. Terrible language 😜
belimawr
reviewed
Jun 26, 2025
belimawr
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add description for package types and how to chose between them.