Update help message for benchmark command#2585
Merged
Conversation
Formatting is weird when not wrapped in code block
Collaborator
💔 Build Failed
Failed CI StepsHistory |
mrodm
reviewed
May 23, 2025
Comment on lines
+190
to
+195
| ``` | ||
| ELASTIC_PACKAGE_ELASTICSEARCH_HOST=https://my-deployment.es.eu-central-1.aws.foundit.no | ||
| ELASTIC_PACKAGE_ELASTICSEARCH_USERNAME=elastic | ||
| ELASTIC_PACKAGE_ELASTICSEARCH_PASSWORD=changeme | ||
| ELASTIC_PACKAGE_KIBANA_HOST=https://my-deployment.kb.eu-central-1.aws.foundit.no:9243 | ||
| ``` |
Contributor
There was a problem hiding this comment.
Hi @philippkahr,
This README file is generated automatically. In order to CI not fail because of that, you should update also this file:
elastic-package/cmd/benchmark.go
Lines 50 to 59 in f090440
That is one of the files that are taken as a source to generate the main README.md
Contributor
|
/test |
mrodm
approved these changes
Jun 13, 2025
jsoriano
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting is weird when not wrapped in code block, we can also do a list