[updatecli] Update default stack version to 8.18.0#2544
Closed
github-actions[bot] wants to merge 0 commit intomainfrom
Closed
[updatecli] Update default stack version to 8.18.0#2544github-actions[bot] wants to merge 0 commit intomainfrom
github-actions[bot] wants to merge 0 commit intomainfrom
Conversation
Contributor
|
There is some change related to Currently, elastic-package/internal/elasticsearch/client.go Lines 224 to 226 in b959f2f Trying this in 8.17.4 results in this response (so failure store is available): However, in 8.18.0 that argument |
Contributor
|
If it is forced to check the failure store in the system tests by applying this patch: --- cmd/testrunner.go
+++ cmd/testrunner.go
@@ -543,10 +543,11 @@ func testRunnerSystemCommandAction(cmd *cobra.Command, args []string) error {
if err != nil {
return err
}
- checkFailureStore, err := esClient.IsFailureStoreAvailable(ctx)
- if err != nil {
- return fmt.Errorf("can't check if failure store is available: %w", err)
- }
+ // checkFailureStore, err := esClient.IsFailureStoreAvailable(ctx)
+ // if err != nil {
+ // return fmt.Errorf("can't check if failure store is available: %w", err)
+ // }
+ checkFailureStore := true
if runTearDown || runTestsOnly {
if variantFlag != "" {The query to check the failure store also fails: |
20d6233 to
b959f2f
Compare
Collaborator
💔 Build Failed
Failed CI Steps
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump elastic-stack default version
[updatecli] Update default stack version to 8.18.0
1 file(s) updated with "$1 \"8.18.0\"": * internal/install/stack_version.go
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!