Update dynamic template for url.original and url.full (import_mappings setting)#2337
Merged
mrodm merged 2 commits intoelastic:mainfrom Jan 14, 2025
Merged
Conversation
Contributor
Author
|
test integrations |
2 tasks
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#12337 |
Update dynamic templates for url.full and url.original fields added when import_mappings setting is enabled
6c3710c to
e785a1a
Compare
Collaborator
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Jan 14, 2025
mrodm
commented
Jan 14, 2025
Contributor
Author
There was a problem hiding this comment.
Updated dynamic templates to be as similar as possible to the ecs@mappings component template:
https://github.com/elastic/elasticsearch/blob/09df99393193b2c53d92899662a8b8b3c55b45cd/x-pack/plugin/core/template-resources/src/main/resources/ecs%40mappings.json#L54-L69
Packages that rely on these dynamic templates should publish a new version in order to get the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #2285
At least, system tests are failing in
cefpackage due to a type set in the mapping forurl.originaldifferent from ECS.That mapping comes from the dynamic templates created with the
import_mappingssetting.This PR tries to solve this error in
cefpackage by updating the ECS mappings thatelastic-packageadds automatically via theimport_mappingssetting.Currently, the embedded dynamic template created by elastic-package when
import_mappingsis enabled does not take any effect (it does not matchpath_match):{ "_embedded_ecs-url_original_to_multifield": { "path_match": "*.url.original", "mapping": { "fields": { "text": { "type": "match_only_text" } }, "type": "wildcard" } } },The goal of this PR is to update that dynamic template to be as similar as possible to the
ecs@mappingscomponent template (withoutunmatch_mapping_typeparameter since it is not supported in 8.6.x):{ "ecs_path_match_wildcard_and_match_only_text": { "path_match": [ "*.body.content", "*url.full", "*url.original" ], "unmatch_mapping_type": "object", "mapping": { "fields": { "text": { "type": "match_only_text" } }, "type": "wildcard" } } },This PR has been tested: