Skip to content

Add false positive package to detect regressions in JSON marshalling#1734

Merged
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:test-package-json-encoding-numbers
Mar 20, 2024
Merged

Add false positive package to detect regressions in JSON marshalling#1734
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:test-package-json-encoding-numbers

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Mar 19, 2024

Add a test package that reproduces the issue fixed in #717. This will help catching regressions caused by not using JSON numbers while decoding documents.

Fixes #732.

@jsoriano jsoriano requested a review from a team March 19, 2024 17:53
@jsoriano jsoriano self-assigned this Mar 19, 2024
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @jsoriano

Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit 72677f0 into elastic:main Mar 20, 2024
@jsoriano jsoriano deleted the test-package-json-encoding-numbers branch March 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit testing for pipeline test runner to cover json decoding and encoding

3 participants