Apply automatic formatting only to manifests#1506
Merged
jsoriano merged 4 commits intoelastic:mainfrom Oct 17, 2023
Merged
Conversation
jsoriano
commented
Oct 16, 2023
internal/formatter/yaml_formatter.go
Outdated
| node.Content = node.Content[:k] | ||
| } | ||
|
|
||
| func quoteKeysWithDot(node *yaml.Node) { |
Member
Author
There was a problem hiding this comment.
Started applying this to test files, but this could also have unexpected results.
This is not used now, if we finally decide not to use it I will remove it.
Contributor
There was a problem hiding this comment.
Not very confident to apply this transformation. Maybe just in transform.yml files ?
Member
Author
There was a problem hiding this comment.
Yeah, after some tests I think this one can be a bit misleading, I am more leaned to remove it, and apply only the automation for nested objects in manifests.
mrodm
reviewed
Oct 17, 2023
internal/formatter/yaml_formatter.go
Outdated
| node.Content = node.Content[:k] | ||
| } | ||
|
|
||
| func quoteKeysWithDot(node *yaml.Node) { |
Contributor
There was a problem hiding this comment.
Not very confident to apply this transformation. Maybe just in transform.yml files ?
Collaborator
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies automation introduced in #1485 so it is only applied to manifests by now.
Applying it to other files like transforms or test configuration files may lead to obscure errors.